Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation fixes #111

Merged
merged 12 commits into from
Jul 29, 2022
Merged

Validation fixes #111

merged 12 commits into from
Jul 29, 2022

Conversation

mpsonntag
Copy link
Collaborator

This PR fixes various issues when running the validation variants:

Further the PR

  • upgrades the Docker "Runner image" version to alpine:3.16
  • upgrades and simplifies the Docker nixio build

Log any occured error from a validation run.
Closes G-Node#106

When a NIX file cannot be opened, the occurrence is
logged as a validation error and the validation continues
with the next NIX file.
Using the latest commit hash of a repository to create
the results badge for a public validation.
Closes G-Node#107

Provide the appropriate error when the BIDS validator is not run
from the root BIDS folder structure.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2761444102

  • 35 of 85 (41.18%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+1.2%) to 37.882%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/web/ginutils.go 0 11 0.0%
internal/web/validate.go 35 74 47.3%
Files with Coverage Reduction New Missed Lines %
internal/web/validate.go 1 47.47%
Totals Coverage Status
Change from base Build 2760462758: 1.2%
Covered Lines: 719
Relevant Lines: 1898

💛 - Coveralls

@mpsonntag mpsonntag merged commit 127e4a0 into G-Node:master Jul 29, 2022
@mpsonntag mpsonntag deleted the validationFixes branch July 29, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants