Implement DataSet::setExtent to allow true resizing (not just extending) and use it where appropriate #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should finally fix issue G-Node#36
|
The old extend method DataSet::extend(NDSize) is now only used twice: In DataArrayHDF5.cpp line 104 not using the new setExtent() seems to be wrong. IMO the old extend() method could be completely replaced and therefore removed. |
|
Fair enough. |
|
Perfect |
stoewer
added a commit
that referenced
this pull request
Jan 28, 2014
Implement DataSet::setExtent to allow true resizing (not just extending) and use it where appropriate
Closed
gicmo
pushed a commit
to gicmo/nix
that referenced
this pull request
Jan 20, 2015
Implement DataSet::setExtent to allow true resizing (not just extending) and use it where appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix a couple of places where we currently use DataSet::extend() which will correctly work in case we enlarge the dataset but not if we want to shrink it. The latter is a problem size in a few places we also relay in DataSet::size() returning the correct size to know how many values are actually in the dataset.
This will also make Values work as expected and so fix issue #36.