add static method for library version to File #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gicmo
reviewed
Nov 5, 2016
|
|
||
| # add the binary tree to the search path for include files | ||
| # so that we will find version.h | ||
| include_directories("${PROJECT_BINARY_DIR}/include/nix") |
There was a problem hiding this comment.
What if we are change that to include_directories("${PROJECT_BINARY_DIR}/include/") and then later on include <nix/libversion.hpp>.
| @@ -16,6 +16,7 @@ | |||
| #include <nix/Platform.hpp> | |||
|
|
|||
| #include <nix/valid/validate.hpp> | |||
| #include "libversion.hpp" | |||
There was a problem hiding this comment.
Should we move this include to nix/Version.hpp?
There was a problem hiding this comment.
would you shift the version method to Version.hpp as well?
gicmo
reviewed
Nov 9, 2016
| * | ||
| * @return the version as a vector<int> in the order major, minor, patch | ||
| */ | ||
| std::vector<int> apiVersion(); |
There was a problem hiding this comment.
do not merge, I will rebase once I have that fixed
jgrewe
force-pushed
the
lib_version
branch
4 times, most recently
from
1c07e31
to
a3171aa
Compare
gicmo
approved these changes
Nov 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
version header is created from the cmake settings. should solve issue #647