Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using pyyaml > 3.12 breaks tests #291

Closed
mpsonntag opened this issue Jun 27, 2018 · 1 comment · Fixed by #316
Closed

Using pyyaml > 3.12 breaks tests #291

mpsonntag opened this issue Jun 27, 2018 · 1 comment · Fixed by #316

Comments

@mpsonntag
Copy link
Contributor

The new release of pyyaml 4.1 breaks tests, there seem to be incompatibilities between the pyyaml versions.
@mpsonntag
Copy link
Contributor Author

It seems, that with the new release of pyyaml 4.1 most python objects are no longer serialized by default and old yaml files containing python object specific code can no longer be easily loaded. This change has been introduced since this addresses an issue where potentially harmful code would have been executed when loading a yaml file. Check here for details.

Our two main problems with this are:

  • pyyaml < 4.1 files cannot be easily be loaded now since they still contain serialized odML python objects e.g. !!python/object/apply:odml.dtypes.DType or python 2 derived !!python/unicode tags.
  • datetime.time values can not be saved, since this serialization currently does not seem to be supported by pyyaml while the serialization of datetime.date and datetime.datetime still works fine.

@mpsonntag mpsonntag mentioned this issue Jul 2, 2018
Merged
mpsonntag added a commit to mpsonntag/python-odml that referenced this issue Feb 13, 2019
@mpsonntag
[setup] Upgrade pyyaml dependency
af78232 
Closes G-Node#291

With pyyaml version 4.2+ the breaking
changes in of version 4.1 have been amended.
mpsonntag added a commit to mpsonntag/python-odml that referenced this issue Feb 13, 2019
@mpsonntag
[setup] Upgrade pyyaml dependency
f855f9b 
Closes G-Node#291

With pyyaml version 4.2+ the breaking
changes of version 4.1 have been amended.
Setting a specific pyyaml version since
all currently 4.2* released versions are
beta making an unspecific pip install unavailable.
@mpsonntag mpsonntag mentioned this issue Feb 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pyyaml dependency upgrade mpsonntag/python-odml
1 participant
@mpsonntag