Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RDF] 'Bag' to 'Seq' #292

Merged
merged 9 commits into from
Jul 4, 2018
Merged

[RDF] 'Bag' to 'Seq' #292

merged 9 commits into from
Jul 4, 2018

Conversation

mpsonntag
Copy link
Contributor

Currently the RDF class Bag is used to store odml.Property values. To note, that the order of the values is important, this PR switches Bag to the RDF container class Seq which implies order. Since rdflib currently does not support proper Seq behaviour with RDF li items, for now the index of the value items will be manually written as RDF properties, which rdflib supports when reading the file in again.

Any suggestions to solve this issue differently are welcome.

This PR further

@coveralls
Copy link

coveralls commented Jul 2, 2018

Coverage Status

Coverage decreased (-0.02%) to 81.763% when pulling 4e4eeb7 on mpsonntag:bagToSeq into eb97b7f on G-Node:master.

Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending Travis build fix

@jgrewe jgrewe merged commit a75d1db into G-Node:master Jul 4, 2018
@mpsonntag mpsonntag deleted the bagToSeq branch July 4, 2018 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants