Skip to content

Conversation

mpsonntag
Copy link
Contributor

@mpsonntag mpsonntag commented Nov 4, 2019

The PR

  • changes the location of the section_subclasses.yaml file from the doc folder to the new odml/resources folder. It also ensures, that the file is properly installed/exported when locally installing via setup.py, pip or when preparing for a PyPI package.

  • updates the available odml->RDF subclasses by new datacite Section types.

  • also includes a small RDFWriter fix - the writer was still using the deprecated Propery.value attribute. It now properly maps the file format Propery.value onto the current Property attribute values.

The PR also adds updates to the DOI section of the project documentation page:

  • fixes invalid DOI link in Dragly reference
  • adds Sprenger DOI reference

Closes G-Node#212

The `section_subclasses.yaml` file is moved from the `doc` folder to the
new `odml/resources` folder. This allows usage of the file with all
install options.
@coveralls
Copy link

coveralls commented Nov 4, 2019

Coverage Status

Coverage decreased (-0.02%) to 74.902% when pulling 0339329 on mpsonntag:rdfsubclasses into 2d9a95d on G-Node:master.

- fix invalid DOI link in Dragly reference
- add Sprenger DOI reference
@jgrewe jgrewe merged commit 6c9294e into G-Node:master Nov 8, 2019
@mpsonntag mpsonntag deleted the rdfsubclasses branch November 11, 2019 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants