RDF converter cleanup #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call `finalize` for every document to make sure all `links` and `includes` are resolved before exporting an odml document to rdf.
Moving the root-ontology.ttl file from doc/odml_ontology to odml/resources/odml-ontology.ttl and include it in packaging via Manifest.in.
jgrewe
reviewed
Nov 13, 2019
| :param node: An RDF node that is used to append the current odml element | ||
| to the RDF graph. If None, a new node will be created and | ||
| added to the 'Hub' node of the RDF graph. | ||
| """ |
There was a problem hiding this comment.
this function is a monster ;) Might be cool to split is up to functions that handle the different subtype separately. Something for the future, maybe.
There was a problem hiding this comment.
I agree, the method is still too big and the suggestion to split it up into subtype handling intrigues me. Lets see what I can do about it...
jgrewe
approved these changes
Nov 13, 2019
To reduce complexity, the RDFWriter.save_elem method is removed and its usage replaced by the new methods RDFWriter.save_document, .save_section and .save_property.
Changed the signature of RDFWriter.save_odml_list so it is identical to the signature of similar methods in the same class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generally cleans up the
rdf_converterfile to reduce method complexity and improve PEP-8 compliancy. It also includes these major improvements:info.pynow provides anINSTALL_PATHvariable. Since therdf_converterdepends on the non-python subclasses fileresources/subclasses.yml, it should now be easier to provide the file path to this file independent of installation type.rdf_converternow features a newload_rdf_subclassesfunction, that either provides the content of theresources/subclasses.ymlfile or, if it cannot be accessed, deals with it without breaking theRDFWriter.odml.Property.valueattribute.finalizemethod to ensure that alllinksandincludesare resolved before exporting to RDF.doc/root-ontology.ttltoodml/resources/odml-ontology.ttland included inManifest.in.