forked from nunit/nunit
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] master from nunit:master #222
Open
pull
wants to merge
48
commits into
G-Research:master
Choose a base branch
from
nunit:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to using license expression
* updating packages * Update packages and fix warnings * Fixing PR comments * Fixed more warnings * Undo changes to NUnit.Analyzer PackageReference * Remove/Move some NUnit suppression This as a result of updating the version of the NUnit.Analyzer * Undo changes to CodeStyle package reference --------- Co-authored-by: Manfred Brands <manfred-brands@users.noreply.github.com>
* Initial implementation of TestCase with TypeArgs * Respond to feedback * TestCaseSource support + tests * Make it fail when TypeArgs omitted * Fix type issues in expected failure test. Rely on nunit API to determine if it fails to run --------- Co-authored-by: Terje Sandstrom <terje@hermit.no>
* Added myget publish workflow/action. * Update name * Namechange * Fix modifier * fix mod 2 * Using minver * Update cmd * fix cake script error * more script error fixes * cake version issues * minver version fixed * a small change * getting all history for minver to work with * Setting minor version to increment after RTM tag. We're working towards new minor version by default. * Changed name of CI build.
Co-authored-by: Sean Killeen <SeanKilleen@gmail.com>
Co-authored-by: Sean Killeen <SeanKilleen@gmail.com>
Co-authored-by: Sean Killeen <SeanKilleen@gmail.com>
Prepare version 4.1
Add 'main' to CI yaml
Properly handle generic ValueTask await adapter
* access concrete assertion results directly instead of interface
Don't generate output content twice in TestResult.AddToXml
* set CI friendly NO_LOGO and CLI_TELEMETRY_OPTOUT
Use obj is Array instead of obj.GetType().IsArray
Add support for Exceptions for Display Name
…mments_not_zero Fixing up misleading xml method descriptions
…rk in TestContextTests.cs
Add Prefix in TestContext.AddTestAttachment for long file paths
Use MemoryExtensions in StreamsComparer for performance
* Remove need for casts when using ConstraintExpression.Append * Fix nullability of StringContraint.Matches * Add `WhiteSpace` Constraint * Add support for `.IgnoreWhiteSpace` modifier to: - AnyOfConstraint - CollectionItemsEqualConstaint - ContainsConstraint - EqualConstraint - UniqueItemsConstraint Updates to Clip String Requires individual clipping when white-space is ignored. We then also need to show two different ^ to indicate the mismatched location. * Code review changes * Make it clear that what the extra size is for when creating StringBuilder
Increment by 'Actual bytes read' rather than the buffer size in StreamsComparer.cs
…ue (fix CS8604) (#4689) * Permit DictionaryContainsKeyValuePairConstraint to take in a null value, matching the nullability of DictionaryEntry. * Fix up nullability of DictionaryContainsValueConstraint to permit `object?` instead of `object`. * Add some basic tests that null values can be found in dictionaries by DictionaryContains(Key)ValueConstraint. * Update DictionaryContainsKeyValueConstraintTests.cs to use [TestCase] instead of [Theory]. * Update DictionaryContainsValueConstraintTests.cs to replace use of [Theory] with [TestCase]. --------- Co-authored-by: Andrew McClement <andrew.mcclement@aveva.com>
* Enabling extension of events * Adding new types as templates, or base classes * Fixing comments from Manfred. * Fix SA1001 * Fix comment * Fix dispose issue * Fixed suggested changes.
* Add "matching items" to message * Add unit test to cover "no matching items" use-case
#4712) * PropertiesComparer: Show actual property and value that fails equality * Simplify code to remove null checks on _failurePoints
Although milliseconds is the natural unit for an `int` delay, specifying can still be helpful just to be sure.
* Fixes Issue #4705 * Delete src/src.sln * Changed to using conditionals in the directory.build.props and adjusted csprojs and assemblyinfo.cs files accordingly. * Adding caketest * Update src/NUnitFramework/framework/nunit.framework.csproj Co-authored-by: Manfred Brands <manfred-brands@users.noreply.github.com> * Update src/NUnitFramework/nunit.framework.legacy/nunit.framework.legacy.csproj Co-authored-by: Manfred Brands <manfred-brands@users.noreply.github.com> * Update src/NUnitFramework/nunitlite/nunitlite.csproj Co-authored-by: Manfred Brands <manfred-brands@users.noreply.github.com> * updated files and directory.build.props * commented out Choose, didnt work, in directory.build.props * Updated some tests, fixing nullrefs * reverted formatting * fix compiler warnings/errors * updated cake * Raise Error when compiling for a TargetFramework with no AssemblyConfiguration .NET 7.0 is out of support as of May 14th 2024. * Fixed null suppressions * Moved cake scripts to its own project and loaded the code into the build.cake * Fix null * Fix more minor stuff * Fix SA warnings * Using same file and assembly version numbers, same as we have done earlier * Final review changes * Fetch tags in CI * Updated to cake 4. Get a warnign about other cake tools like minver, raised a PR there too, but the warning can be safely ignored for now * Now we can use AsSpan in CakeScript --------- Co-authored-by: Manfred Brands <manfred-brands@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )