-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Add postgresql client to app service #10781
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10781 +/- ##
=============================================
+ Coverage 38.27% 67.89% +29.61%
Complexity 1652 1652
=============================================
Files 1021 234 -787
Lines 31191 6052 -25139
Branches 6509 0 -6509
=============================================
- Hits 11939 4109 -7830
+ Misses 19075 1943 -17132
+ Partials 177 0 -177
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Perhaps you missed the step to rebuild the webserver container? Or if you did, maybe it didn't do it and you can try the |
Okay, I ran through the steps again and it worked. 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, looks good
Yeah, true. I asked Eric if he wanted me to roll back those changes in this PR but he said the way it is now is fine. |
🤖 Resolves #10777
👋 Introduction
This branch adds the postgresql to the app service setup to ensure that a fresh setup is possible. It also adds it to the local webserver docker container to mirror the setup.
🕵️ Details
I created a custom Dockerfile for the webserver image. Before, we were pretty strict about using a pristine image but this is a convenient way to mimic some of the customization we perform on the image during post-deploy.
🧪 Testing
🏠 Locally
docker-compose build webserver
docker-compose exec webserver sh -c "php /home/site/wwwroot/api/artisan migrate:fresh"
☁️ Azure
php /home/site/wwwroot/api/artisan migrate:fresh
📸 Screenshot