feat: Pyramid element for Discontinuous Galerkin for wave solvers #3793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paveltomin
changed the title
acitrain
approved these changes
Aug 26, 2025
|
@acitrain @RoyerJu64 this is not yet approved to be in Merge Queue |
|
@rrsettgast @CusiniM @paveltomin can one of review this please? It is ready to go. |
paveltomin
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the pyramidal element in the Discontinuous Galerkin method, following the Bergot–Cohen–Duruflé construction.
This implementation includes the evaluation of basis functions and their derivatives, as well as the assembly of mass and stiffness matrices on the reference pyramid.