Skip to content

Conversation

paveltomin
Copy link
Collaborator

@paveltomin paveltomin commented Aug 29, 2025

should address #3778

@paveltomin paveltomin self-assigned this Aug 29, 2025
@paveltomin paveltomin requested a review from CusiniM as a code owner August 29, 2025 17:03
@paveltomin paveltomin added the type: feature New feature or request label Aug 29, 2025
@paveltomin paveltomin added flag: ready for review ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Aug 29, 2025
@paveltomin paveltomin added flag: no rebaseline Does not require rebaseline and removed ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Aug 29, 2025
@paveltomin paveltomin requested a review from Copilot September 3, 2025 23:10
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables crossflow logic for well producers by refactoring the crossflow handling mechanism. Previously, crossflow could only be disabled for injectors, but now both injectors and producers can have crossflow enabled or disabled based on configuration.

  • Replaced single boolean disableReservoirToWellFlow with two separate flags isInjector and isCrossflowEnabled
  • Updated crossflow logic to handle both injector and producer wells consistently
  • Removed the validation constraint that prevented crossflow configuration for producers

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
PerforationFluxKernels.hpp Refactored kernel constructors and crossflow logic to use separate injector and crossflow flags
WellControls.cpp Removed validation that prohibited crossflow configuration for producers
CompositionalMultiphaseWell.cpp Updated kernel factory calls to pass separate injector and crossflow flags

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@dkachuma dkachuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this still work if the user disables cross flow?

@paveltomin paveltomin added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI and removed flag: ready for review labels Sep 9, 2025
@paveltomin paveltomin merged commit a9876fb into develop Sep 9, 2025
25 of 26 checks passed
@paveltomin paveltomin deleted the pt/prod-crossflow branch September 9, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants