fix: change validation for region statistics for by resvol constraint #3829
+61
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjb-ltk
requested review from
rrsettgast,
paveltomin,
CusiniM,
dkachuma,
rasimHZ and
OmarDuran
as code owners
MelReyCG
reviewed
Sep 24, 2025
There was a problem hiding this comment.
Maybe, to not expose the statistics component to the user, you can add in the well solver's registerDataOnMesh():
if( !wellControls.referenceReservoirRegion().empty() )
{
// we need a statistics component for reference region pressure
m_referenceRegionStats = taskManager.registerGroup<SinglePhaseStatistics>( "internalStats" )
.setRestartFlags(NO_WRITE);
m_referenceRegionStats.registerDataOnMeshRecursive(meshBodies);
}m_referenceRegionStats would be a pointer or an std::optional, then you can call its execute() before reading it in updateVolRateForConstraint()
| } | ||
|
|
||
| void CompositionalMultiphaseWell::updateVolRatesForConstraint( WellElementSubRegion & subRegion ) | ||
| void CompositionalMultiphaseWell::updateVolRatesForConstraint( ElementRegionManager const & elemManager, WellElementSubRegion & subRegion ) |
There was a problem hiding this comment.
(same for SinglePhaseWell)
Suggested change
| void CompositionalMultiphaseWell::updateVolRatesForConstraint( ElementRegionManager const & elemManager, WellElementSubRegion & subRegion ) | |
| void CompositionalMultiphaseWell::updateVolRatesForConstraint( ElementRegionManager const & elemManager, | |
| WellElementSubRegion & subRegion ) |
| * @param targetIndex the targetIndex of the subRegion | ||
| */ | ||
| void updateVolRatesForConstraint( WellElementSubRegion & subRegion ); | ||
| void updateVolRatesForConstraint( ElementRegionManager const & elemManager, WellElementSubRegion & subRegion ); |
There was a problem hiding this comment.
(same for SinglePhaseWell)
Suggested change
| void updateVolRatesForConstraint( ElementRegionManager const & elemManager, WellElementSubRegion & subRegion ); | |
| void updateVolRatesForConstraint( ElementRegionManager const & elemManager, | |
| WellElementSubRegion & subRegion ); |
|
We are testing the current state of the branch |
|
No success. I'll create a branch / PR on top of this one to contribute on this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reservoir volume constraint needs region average quantities for computing fluid properties. The ave quantities are computed via tasks such as CompositionalMultiphaseStatistics (and SinglePhaseStatistics equivalent) that are triggered in event section
Previously validation attempted to check if compute statistics wrappers were present on region. This was incorrect. but maybe the region should own the statistics object.
New check looks at if region ave quantities are zero.
integrated tests are forthcoming..