Skip to content

Conversation

frankfeifan
Copy link
Collaborator

@frankfeifan frankfeifan commented Jul 25, 2025

This is a dedicated PR for MoMaS Benchmark problem

Copy link

codecov bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (057bb05) to head (e6406e5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #11   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        23    +1     
  Lines          748       784   +36     
=========================================
+ Hits           748       784   +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rrsettgast
Copy link
Member

Generating image form_3_dark.png/tmp/hpcReact/src/reactions/reactionsSystems/EquilibriumReactions.hpp:105: warning: Member enforceEquilibrium_Aggregate(RealType const &temperature, PARAMS_DATA const &params, ARRAY_1D_TO_CONST const &targetAggregatePrimarySpeciesConcentration, ARRAY_1D_TO_CONST const &logPrimarySpeciesConcentration0, ARRAY_1D &speciesConcentration) (function) of class hpcReact::reactionsSystems::EquilibriumReactions is not documented.
<enforceEquilibrium_Aggregate>:1: warning: parameters of member hpcReact::reactionsSystems::EquilibriumReactions::enforceEquilibrium_Aggregate are not documented
 for formula

@rrsettgast rrsettgast merged commit f20e43a into main Sep 3, 2025
11 checks passed
@rrsettgast rrsettgast deleted the momasBenchmark branch September 3, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants