Query project crs every time the centroid tool is used #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And not just once during plugin Initiation.
MichaelsJP
requested changes
Nov 2, 2023
| @@ -446,7 +446,7 @@ def _linetool_annotate_point(self, point, idx): | |||
| annotation.setFrameSizeMm(QSizeF(7, 5)) | |||
| annotation.setFrameOffsetFromReferencePointMm(QPointF(1.3, 1.3)) | |||
| annotation.setMapPosition(point) | |||
There was a problem hiding this comment.
Shouldn't the point also be transformed like in the _on_linetool_map_click function?
transformer = transform.transformToWGS(map_crs)
point_wgs = transformer.transform(point)
There was a problem hiding this comment.
The point is passed from _on_linetool_map_click to _linetool_annotate_point, and it is already transformed, isn't it? Maybe the crs should also be passed and not retrieved again. Or do I still not understand what you mean?
There was a problem hiding this comment.
Cool. Wasn't aware of the sequence the functions are called. If no coordinates reach _linetool_annotate_point without being transformed, forget my comment ;).
Will give you a go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And not just once during plugin Initiation.