-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: set up formatting and linting #197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finnaly had the chance to test this out locally. Everything works fine.
3 Things from my side:
1: Would squash the first 3 commits and tag as type ci
instead of build
as it's GH actions.
2: drop bb87a1b & 2bde6ac as it's + x - x
3: I remember some issues todo with a missing resources_rc, maybe double check that removing the from . import resources_rc
from ORSToolsDialog.py won't cause issues after e.g. recompiling resources.qrc. But prob. it's fine.
0dcc8f6
to
3a40120
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
27ad15b
to
ace62dc
Compare
Following the discussion, we decided to use ruff as a linter/autoformatter.
Configuration only excludes autogenerated files and sets line length to 100.
Fixes #141