Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: set up formatting and linting #197

Merged
merged 7 commits into from
Dec 6, 2023
Merged

Conversation

koebi
Copy link
Collaborator

@koebi koebi commented Nov 23, 2023

Following the discussion, we decided to use ruff as a linter/autoformatter.

Configuration only excludes autogenerated files and sets line length to 100.

Fixes #141

Copy link
Collaborator

@TheGreatRefrigerator TheGreatRefrigerator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finnaly had the chance to test this out locally. Everything works fine.

3 Things from my side:

1: Would squash the first 3 commits and tag as type ci instead of build as it's GH actions.

2: drop bb87a1b & 2bde6ac as it's + x - x

3: I remember some issues todo with a missing resources_rc, maybe double check that removing the from . import resources_rc from ORSToolsDialog.py won't cause issues after e.g. recompiling resources.qrc. But prob. it's fine.

@koebi koebi force-pushed the feature/141-format-and-lint branch from 0dcc8f6 to 3a40120 Compare December 4, 2023 09:17
@TheGreatRefrigerator TheGreatRefrigerator changed the title build: set up formatting and linking build: set up formatting and linting Dec 6, 2023
Copy link
Collaborator

@TheGreatRefrigerator TheGreatRefrigerator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@koebi koebi force-pushed the feature/141-format-and-lint branch from 27ad15b to ace62dc Compare December 6, 2023 16:16
@koebi koebi merged commit bdb7974 into main Dec 6, 2023
2 checks passed
@koebi koebi deleted the feature/141-format-and-lint branch December 6, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce automated code style formatting and linting
3 participants