Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace removesuffix() function with replace() function #217

Merged
merged 4 commits into from
Jan 15, 2024
Merged

fix: replace removesuffix() function with replace() function #217

merged 4 commits into from
Jan 15, 2024

Conversation

merydian
Copy link
Collaborator

No description provided.

@merydian merydian linked an issue Jan 11, 2024 that may be closed by this pull request
<str>.removesuffix() only available in Python3.9 #215
Closed
@merydian merydian requested a review from koebi January 11, 2024 13:20
koebi
koebi approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@koebi koebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I like the removeprefix and removesuffix better.
Changelog entry is missing ;)

@koebi koebi marked this pull request as ready for review January 15, 2024 09:05
@koebi koebi merged commit 2c16bcc into main Jan 15, 2024
2 checks passed
@koebi koebi deleted the 215-strremovesuffix-only-available-in-python39 branch January 15, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koebi koebi koebi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<str>.removesuffix() only available in Python3.9
2 participants
@merydian @koebi