Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish python-apollo testing #2308

Merged
merged 30 commits into from
Nov 6, 2019
Merged

Finish python-apollo testing #2308

merged 30 commits into from
Nov 6, 2019

Conversation

abretaud
Copy link
Collaborator

@abretaud abretaud commented Nov 6, 2019

So we're getting closer to a working python-apollo testing
Is there a default user in the apollo launched in travis, or should I create it?

fixes #2285

@nathandunn
Copy link
Contributor

best PR request ever:

image

@nathandunn
Copy link
Contributor

@abretaud I haven't tested for sure, bit it looks like there is one: https://docs.travis-ci.com/user/environment-variables/#default-environment-variables

@abretaud
Copy link
Collaborator Author

abretaud commented Nov 6, 2019

yes, I was tempted to squash, but I got lazy :)

I meant an apollo user/password to use the api of the one launched in travis (it fails with auth error)

@nathandunn
Copy link
Contributor

Yeah, there is a way to do this with the apollo-config.groovy file.

https://genomearchitect.readthedocs.io/en/latest/Configure.html#register-admin-in-configuration

@nathandunn
Copy link
Contributor

but . . . maybe with docker there might be a default, let me check.

@abretaud
Copy link
Collaborator Author

abretaud commented Nov 6, 2019

Yep with docker there admin@local.host, but on travis it's not using docker (as it's not yet built on quay.io), it's running apollo with grailsw run-app, so I guess we should add some conf to have an admin user

@nathandunn
Copy link
Contributor

@abretaud Looks like under test/config you can add a config file adding the admin (say using the h2 version) and set the admin password that way. I added this:

abretaud#1

@abretaud
Copy link
Collaborator Author

abretaud commented Nov 6, 2019

Cooool, it's green now https://travis-ci.org/abretaud/Apollo/jobs/608313434 !

@nathandunn
Copy link
Contributor

Note.

Fixes #2285

@nathandunn nathandunn merged commit 0741181 into GMOD:develop Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add apollo-arrow tests to run within travis
2 participants