Allow disabling derives from references #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmdcolin
force-pushed
the
disable_derives_from
branch
from
f329d60
to
fc24636
Compare
cmdcolin
force-pushed
the
disable_derives_from
branch
from
fc24636
to
1f5b8aa
Compare
|
I like this approach better than the one in #56. This change here is smaller, and is more explicit that this is disabling support for part of the GFF3 spec. |
|
sounds good, i agree it's a bit more straightforward |
|
maybe can merge for now, if we discover a reason we need it, can re-enable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option allows fully disabling derives from reference resolving. This is an alternative to #56 that just disables the resolution of Derives_from entries
I would probably suggest turning it on by default in jbrowse 2