Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable resolution of Derives_from fields in GFF3 parsing, fixes TAIR gff #3272

Merged
merged 2 commits into from Oct 19, 2022

Conversation

cmdcolin
Copy link
Collaborator

works in tandem with GMOD/gff-js#56

Screenshot from 2022-10-14 01-24-47

can see in screenshot, the "transposable element derived genes" are shown

example text

chr1    TAIR10  transposable_element_gene       433031  433819  .       -       .       ID=AT1G02228;Note=transposable_element_gene;Name=AT1G02228;Derives_from=AT1TE01405
chr1    TAIR10  mRNA_TE_gene    433031  433819  .       -       .       ID=AT1G02228.1;Parent=AT1G02228;Name=AT1G02228.1;Index=1
chr1    TAIR10  exon    433031  433819  .       -       .       Parent=AT1G02228.1
chr1    TAIR10  gene    435174  436776  .       -       .       ID=AT1G02230;Note=protein_coding_gene;Name=AT1G02230
chr1    TAIR10  mRNA    435174  436776  .       -       .       ID=AT1G02230.1;Parent=AT1G02230;Name=AT1G02230.1;Index=1
chr1    TAIR10  protein 435174  436775  .       -       .       ID=AT1G02230.1-Protein;Name=AT1G02230.1;Derives_from=AT1G02230.1
chr1    TAIR10  five_prime_UTR  436776  436776  .       -       .       Parent=AT1G02230.1
chr1    TAIR10  CDS     436622  436775  .       -       0       Parent=AT1G02230.1,AT1G02230.1-Protein;
chr1    TAIR10  exon    436622  436776  .       -       .       Parent=AT1G02230.1
chr1    TAIR10  CDS     436277  436539  .       -       2       Parent=AT1G02230.1,AT1G02230.1-Protein;
chr1    TAIR10  exon    436277  436539  .       -       .       Parent=AT1G02230.1
chr1    TAIR10  CDS     435997  436128  .       -       0       Parent=AT1G02230.1,AT1G02230.1-Protein;
chr1    TAIR10  exon    435997  436128  .       -       .       Parent=AT1G02230.1
chr1    TAIR10  CDS     435650  435916  .       -       0       Parent=AT1G02230.1,AT1G02230.1-Protein;
chr1    TAIR10  exon    435650  435916  .       -       .       Parent=AT1G02230.1

the AT1TE01405 is not in the gff, which previously caused crashes but is more related to the @gmod/gff pr

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Oct 14, 2022
@cmdcolin

This comment was marked as outdated.

@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Oct 14, 2022
@cmdcolin cmdcolin changed the title Add display of derived features in feature details Remove the resolution of Derives_from fields in GFF3 parsing Oct 17, 2022
@cmdcolin
Copy link
Collaborator Author

I updated this so that instead of resolving the Derives_from, to just display the field as is GMOD/gff-js#57

Updated screenshot showing TAIR gff
Screenshot from 2022-10-17 11-53-10

Has protein features with CDS subfeatures that are displayed now instead of hidden (previously, they would be made "subfeatures" (put into the "derived_from" attribute) of the gene they "derive from")

Could be said that this is visually noisy to display them, but i'd say in general, making it easier to filter a gff is a better approach than trying to optimize out the visual noise in this case

@cmdcolin cmdcolin changed the title Remove the resolution of Derives_from fields in GFF3 parsing Disable resolution of Derives_from fields in GFF3 parsing, fixes TAIR gff Oct 19, 2022
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #3272 (60e1d8d) into main (3bbf659) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3272      +/-   ##
==========================================
- Coverage   59.44%   59.43%   -0.01%     
==========================================
  Files         676      676              
  Lines       28828    28826       -2     
  Branches     7039     7039              
==========================================
- Hits        17138    17134       -4     
- Misses      11416    11418       +2     
  Partials      274      274              
Impacted Files Coverage Δ
plugins/gff3/src/Gff3Adapter/Gff3Adapter.ts 87.95% <ø> (-0.15%) ⬇️
...gins/gff3/src/Gff3TabixAdapter/Gff3TabixAdapter.ts 87.61% <ø> (-0.12%) ⬇️
plugins/alignments/src/BamAdapter/BamAdapter.ts 72.07% <0.00%> (-0.91%) ⬇️
...ments/src/SNPCoverageAdapter/SNPCoverageAdapter.ts 57.33% <0.00%> (-0.67%) ⬇️
products/jbrowse-web/src/util.ts 48.33% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin merged commit f96ec17 into main Oct 19, 2022
@cmdcolin cmdcolin deleted the derived_feats branch October 19, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant