Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move building and testing from Travis to GitHub Workflow #1448

Merged
merged 3 commits into from
Nov 16, 2020

Conversation

garrettjstevens
Copy link
Collaborator

@elliothershberg and I worked on this together. This removes .travis.yml and moves the testing and build steps to two new workflows that run on every push:

  • test
    • runs tests
    • uploads coverage
    • checks typescript types
  • build
    • builds codebase
    • runs build-only tests
    • uploads branch build to S3 in the same location Travis did

So far the build step takes the longest at right around 20 minutes, and we haven't seen any builds time out.

Fixes #1328

@cmdcolin
Copy link
Collaborator

wow, big win! sad to see travis go but this looks much better if the stability holds

@elliothershberg
Copy link
Member

Yeah I think getting down to ~20 min from ~35 will be really nice

@elliothershberg
Copy link
Member

elliothershberg commented Nov 16, 2020

If we switch to GH Actions, it looks like they have their own API for badges: docs

Would look like this: Push

So maybe worth renaming from Push to Build? If we want to keep using shields.io with the same style it would look something like this:

[![Build Status](https://img.shields.io/github/workflow/status/GMOD/jbrowse-components/Push/master?logo=github&style=for-the-badge)]()

Build Status

(example using this branch instead of master), but I'm not sure what the the URL would be to link to results of the action.

We could do something like:

https://github.com/GMOD/jbrowse-components/actions?query=workflow%3APush+branch%3Amaster+

which would link to the results of Push (or Build) for master

@rbuels rbuels merged commit 4ff75c2 into master Nov 16, 2020
@rbuels rbuels deleted the 1328_build_workflow branch November 16, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yarn build step in Travis-CI builds timing out
4 participants