Add Material UI's DataGrid to re-exports #1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
Codecov Report
@@ Coverage Diff @@
## main #1864 +/- ##
=======================================
Coverage 58.55% 58.56%
=======================================
Files 460 460
Lines 21331 21331
Branches 5090 5090
=======================================
+ Hits 12491 12493 +2
+ Misses 8534 8532 -2
Partials 306 306
Continue to review full report at Codecov.
|
cmdcolin
force-pushed
the
data_grid_reexports
branch
from
8359b4e
to
501734c
Compare
garrettjstevens
added
enhancement
|
note that this could be a good candidate for lazy loading. It would be unfortunate to break user code that relies on this re-export to be static, but if we make it a lazy(() => import(...)) then it could kick it out of the main thread |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@peterkxie is using the data-grid in the Apollo plugin, but it was proving hard to install in the plugin due to some conflicts with how we re-export Material UI for plugins. There are probably some improvements that could be made to make that easier, but as a first step, since the DataGrid is already in the peerDeps of core and is a useful component, I think we may as well re-export it so it's easy to use.