Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about legacy-peer-deps to embedded component readme #2253

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

cmdcolin
Copy link
Collaborator

Fixes #1943

If we don't want to suggest legacy-peer-deps we might need #1727 and maybe even other evaluations of our many dependencies and their peerDependencies...it's just quite a picky system sometimes

Also removes storybook note from circular view

@garrettjstevens is the circular view storybook published?

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Aug 25, 2021
@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #2253 (7095ada) into main (60b4ef3) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2253      +/-   ##
==========================================
+ Coverage   62.88%   62.90%   +0.01%     
==========================================
  Files         493      493              
  Lines       22907    22907              
  Branches     5178     5178              
==========================================
+ Hits        14405    14409       +4     
+ Misses       8236     8232       -4     
  Partials      266      266              
Impacted Files Coverage Δ
packages/core/util/io/rangeFetcher.ts 90.24% <0.00%> (-2.44%) ⬇️
packages/core/assemblyManager/assemblyManager.ts 67.10% <0.00%> (-1.32%) ⬇️
...nts/src/SNPCoverageRenderer/SNPCoverageRenderer.ts 87.65% <0.00%> (+7.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60b4ef3...7095ada. Read the comment docs.

@cmdcolin cmdcolin added documentation and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Aug 25, 2021
@cmdcolin cmdcolin merged commit c7facb2 into main Sep 1, 2021
@cmdcolin cmdcolin deleted the legacy-peer-deps-readme branch September 1, 2021 14:29
@cmdcolin cmdcolin changed the title Add note about legacy-peer-deps to readme Add note about legacy-peer-deps to embedded component readme Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage with npm instead of yarn
2 participants