-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag to text-index cli subcommand to create text-index for embedded mode #2296
Conversation
Note: this will most likely delay the release of text-searching |
maybe we push back release day to tomorrow or something? or we can release without this pr, probably ok too |
@cmdcolin I am ok with releasing without this PR. However, this PR introduces a small change to the meta.json. Do we want to wait to get the label enhancements merged? |
#2289 (label enhancement) likely won't be done yet. I'm not confident in the trix-js code underlying it yet so it is draft and we could release without it |
Ok, I think we can go ahead with the release then. |
…iles, modify meta file to add list of files indexed
Closing, this is getting addressed in #2303 |
WIP: In this PR issue 2282
Adds support to index single or multiple files without the need for a config.json
Adds support to index files for embedded mode
TODO:
currently using similar logic to guess adapter from add assembly