Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to text-index cli subcommand to create text-index for embedded mode #2296

Closed
wants to merge 5 commits into from

Conversation

teresam856
Copy link
Contributor

WIP: In this PR issue 2282
Adds support to index single or multiple files without the need for a config.json
Adds support to index files for embedded mode

TODO:

  • support local files
  • better guess for adapter from filenames
    currently using similar logic to guess adapter from add assembly
  • refactor index driver

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Sep 7, 2021
@teresam856 teresam856 changed the title Text index files Add flag to text-index cli subcommand to create text-index for embedded mode Sep 7, 2021
@teresam856
Copy link
Contributor Author

Note: this will most likely delay the release of text-searching
Other discussiona found here Update trix to return the matched search term if it is not part of the label

@teresam856 teresam856 added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Sep 7, 2021
@teresam856 teresam856 marked this pull request as draft September 7, 2021 01:03
@teresam856 teresam856 self-assigned this Sep 7, 2021
@teresam856 teresam856 linked an issue Sep 7, 2021 that may be closed by this pull request
@cmdcolin
Copy link
Collaborator

cmdcolin commented Sep 7, 2021

maybe we push back release day to tomorrow or something? or we can release without this pr, probably ok too

@teresam856
Copy link
Contributor Author

teresam856 commented Sep 7, 2021

maybe we push back release day to tomorrow or something? or we can release without this pr, probably ok too

@cmdcolin I am ok with releasing without this PR. However, this PR introduces a small change to the meta.json. Do we want to wait to get the label enhancements merged?

@cmdcolin
Copy link
Collaborator

cmdcolin commented Sep 7, 2021

#2289 (label enhancement) likely won't be done yet. I'm not confident in the trix-js code underlying it yet so it is draft and we could release without it

@teresam856
Copy link
Contributor Author

Ok, I think we can go ahead with the release then.

@teresam856
Copy link
Contributor Author

Closing, this is getting addressed in #2303

@teresam856 teresam856 closed this Sep 8, 2021
@cmdcolin cmdcolin deleted the text_index_files branch January 10, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a text-index CLI mode for embedded use cases
2 participants