Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adapterType dropdown in add track widget #2688

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Conversation

cmdcolin
Copy link
Collaborator

xref https://github.com/GMOD/jbrowse-plugin-apollo/issues/38

Makes the regex less specific, so that if adapterHint is GtfAdapter and it visits VcfAdapter's Core-guessAdapterType, the regex doesn't say that it is a VcfAdapter.

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jan 28, 2022
@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #2688 (6d3a549) into main (403788e) will decrease coverage by 0.00%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2688      +/-   ##
==========================================
- Coverage   60.69%   60.69%   -0.01%     
==========================================
  Files         561      561              
  Lines       26313    26346      +33     
  Branches     6409     6421      +12     
==========================================
+ Hits        15971    15990      +19     
- Misses      10016    10030      +14     
  Partials      326      326              
Impacted Files Coverage Δ
.../sequence/src/GCContentAdapter/GCContentAdapter.ts 0.00% <0.00%> (ø)
plugins/bed/src/index.ts 81.81% <60.00%> (-1.52%) ⬇️
plugins/gff3/src/index.ts 84.84% <60.00%> (-1.82%) ⬇️
plugins/gtf/src/index.ts 83.33% <60.00%> (-3.34%) ⬇️
plugins/wiggle/src/index.ts 92.50% <60.00%> (-2.10%) ⬇️
plugins/sequence/src/index.ts 85.22% <62.50%> (-0.85%) ⬇️
plugins/hic/src/index.ts 97.36% <80.00%> (-2.64%) ⬇️
plugins/variants/src/index.ts 94.23% <83.33%> (-1.69%) ⬇️
plugins/alignments/src/index.ts 97.67% <91.66%> (-2.33%) ⬇️
packages/core/util/tracks.ts 75.00% <100.00%> (-0.31%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dfdf88...6d3a549. Read the comment docs.

@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jan 28, 2022
@cmdcolin cmdcolin merged commit 0f02867 into main Jan 28, 2022
@cmdcolin cmdcolin deleted the fix_adapter_inference2 branch January 28, 2022 21:11
@cmdcolin
Copy link
Collaborator Author

hotfix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant