Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in desktop where first track gets stuck loading #2819

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

garrettjstevens
Copy link
Collaborator

Fixes #2818

This copies rpc.worker.ts from web to desktop. They had diverged a bit in form, but were still doing the same thing, so this hopefully makes them easier to maintain. #2818 was caused by #2798 incorrectly applying the the same change to both these files.

@garrettjstevens garrettjstevens added the bug Something isn't working label Mar 16, 2022
@garrettjstevens garrettjstevens self-assigned this Mar 16, 2022
@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #2819 (3066d1b) into main (c72cea5) will increase coverage by 0.00%.
The diff coverage is 10.00%.

@@           Coverage Diff           @@
##             main    #2819   +/-   ##
=======================================
  Coverage   59.98%   59.98%           
=======================================
  Files         584      584           
  Lines       26690    26689    -1     
  Branches     6463     6462    -1     
=======================================
  Hits        16010    16010           
+ Misses      10350    10349    -1     
  Partials      330      330           
Impacted Files Coverage Δ
products/jbrowse-desktop/src/rpc.worker.ts 26.82% <10.00%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c72cea5...3066d1b. Read the comment docs.

@cmdcolin
Copy link
Collaborator

👍

@cmdcolin cmdcolin merged commit 9e88688 into main Mar 16, 2022
@cmdcolin cmdcolin deleted the 2818_rpc_worker branch March 16, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gff3 problem
2 participants