Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup scroll on wiggle tracks with trackLabels->offset #2821

Merged
merged 3 commits into from
Mar 16, 2022

Conversation

cmdcolin
Copy link
Collaborator

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Mar 16, 2022
@cmdcolin
Copy link
Collaborator Author

I added a couple more changes that preserves the double line and fixes the scroll

@cmdcolin cmdcolin force-pushed the fix_scroll_tracklabels_offset branch from e6f15c6 to cc5e099 Compare March 16, 2022 16:57
@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #2821 (cc5e099) into main (4ad5d56) will decrease coverage by 0.01%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main    #2821      +/-   ##
==========================================
- Coverage   60.00%   59.99%   -0.02%     
==========================================
  Files         584      584              
  Lines       26689    26687       -2     
  Branches     6462     6462              
==========================================
- Hits        16014    16010       -4     
- Misses      10345    10349       +4     
+ Partials      330      328       -2     
Impacted Files Coverage Δ
...rc/LinearGenomeView/components/TracksContainer.tsx 63.75% <ø> (ø)
...ns/wiggle/src/LinePlotRenderer/LinePlotRenderer.js 67.30% <ø> (-2.34%) ⬇️
...src/LinearGenomeView/components/TrackContainer.tsx 86.84% <80.00%> (+6.28%) ⬆️
packages/core/TextSearch/TextSearchManager.ts 96.55% <0.00%> (-3.45%) ⬇️
...inearGenomeView/components/RefNameAutocomplete.tsx 77.77% <0.00%> (-3.04%) ⬇️
.../linear-genome-view/src/LinearGenomeView/index.tsx 85.10% <0.00%> (-0.18%) ⬇️
packages/core/util/analytics.ts 91.83% <0.00%> (+2.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ad5d56...cc5e099. Read the comment docs.

@cmdcolin cmdcolin removed the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Mar 16, 2022
@cmdcolin cmdcolin force-pushed the fix_scroll_tracklabels_offset branch from cc5e099 to 044abdf Compare March 16, 2022 17:37
@cmdcolin cmdcolin changed the title Fixup scroll on bigwig with tracklabels offset Fixup scroll on wiggle tracks with trackLabels->offset Mar 16, 2022
@cmdcolin cmdcolin merged commit de6fa2c into main Mar 16, 2022
@cmdcolin cmdcolin deleted the fix_scroll_tracklabels_offset branch March 16, 2022 17:38
@garrettjstevens garrettjstevens added the bug Something isn't working label Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants