Preserve double border line when using trackLabel offset and use smaller gap between snpcoverage and reads

[cmdcolin]

This removes the border below the track label when using track labels: offset (the default is overlapping). It is a subtle change but i think it makes the offset mode more clear

It changes to use a div instead of a paper
this PR

main

Also removes a double line near the scalebar in the overlapping(default) mode

this PR

main

[codecov]

Codecov Report

Merging #2678 (f699255) into main (fd12bf9) will decrease coverage by 0.04%.
The diff coverage is 47.61%.

@@            Coverage Diff             @@
##             main    #2678      +/-   ##
==========================================
- Coverage   60.21%   60.17%   -0.05%     
==========================================
  Files         572      572              
  Lines       26611    26609       -2     
  Branches     6486     6484       -2     
==========================================
- Hits        16024    16011      -13     
- Misses      10262    10273      +11     
  Partials      325      325              

Impacted Files	Coverage Δ
...ments/src/LinearAlignmentsDisplay/models/model.tsx	68.88% <ø> (ø)
...AlignmentsDisplay/components/AlignmentsDisplay.tsx	56.25% <46.15%> (+12.50%)	⬆️
...src/LinearGenomeView/components/TrackContainer.tsx	80.55% <50.00%> (-1.03%)	⬇️
...s/svg/src/SvgFeatureRenderer/components/Chevron.js	87.17% <0.00%> (-10.26%)	⬇️
packages/core/TextSearch/TextSearchManager.ts	96.55% <0.00%> (-3.45%)	⬇️
...inearGenomeView/components/RefNameAutocomplete.tsx	77.77% <0.00%> (-3.04%)	⬇️
packages/core/util/analytics.ts	89.79% <0.00%> (-2.05%)	⬇️
...gins/svg/src/SvgFeatureRenderer/components/util.ts	92.72% <0.00%> (-1.82%)	⬇️
...gFeatureRenderer/components/ProcessedTranscript.js	85.13% <0.00%> (-1.36%)	⬇️
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd12bf9...f699255. Read the comment docs.

[cmdcolin]

@garrettjstevens is this ok? any reason to prefer the Paper component?

[garrettjstevens]

I prefer the look of using the Paper component. I think the top line gives a good visual cue of which track label mode you are using.

If we do change it, though, I think the color should be theme.palette.divider instead of lightgray so that it matches the theme, especially if we start using dark mode more.

[cmdcolin]

I guess my preference would be for minimizing the lines in the interface. The border lines look less like a border and more like a weird double line in the overlapping mode and in the offset mode, it kind of looks like an empty track with no features with a labelless track below it

[cmdcolin]

good catch on the theme.palette.divider, i changed it to that

[cmdcolin]

any updates on this one?

[cmdcolin]

Instead of using track borders at all now, the track border is removed, and instead, the resize handle between tracks is colored with theme.palette.divider (grey)

before

after

I considered also making the resize handle between pileup and snpcov in the alignments track visible with grey but did not, i did make the distance smaller though

[garrettjstevens]

I'm still seeing a border-bottom when testing this out. Also, I find the resize handle a lot harder to click with it being reduced to 2 pixels from 3.

[cmdcolin]

woops, I had an unpushed commit about the border. also debated the 2 vs 3 pixel height, pushed 3 here

[cmdcolin]

compare link

https://jbrowse.org/code/jb2/track_container_border/?config=test_data%2Fvolvox%2Fconfig.json&session=share-YEYTyhk3ma&password=TVK0t
https://jbrowse.org/code/jb2/main/?config=test_data%2Fvolvox%2Fconfig.json&session=share-YEYTyhk3ma&password=TVK0t

[cmdcolin]

I restored the border after looking at the comparison for a bit. The double border line creates a bit of a visual queue that is helpful, and it can be little hard to distinguish features e.g. introns from the 3px resize handle if it is solid

This PR still contains some miscellaneous changes.

Including

• The absolute positioning is removed and border-box because I could not see any effect.
• The TrackLabel is put inside the Paper, so that the outline is not below the track label
• Smaller area between the coverage and pileup on alignments tracks