Add babel/runtime to dependencies #2923
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our root
babel.config.js
uses@babel/transform-runtime
. According to the docs here, anything that uses that plugin needs to include@babel/runtime
as a dependency. This PR adds that dependency to anything that uses the rootbabel.config.js
.It also removes the
.babelrc
files from the individual plugins since@babel/preset-react
and@babel/preset-env
are already included in the root babel config. It also adds theloose: false
option to the root babel config since it was used in the plugin configs.I noticed this because when I tried to upgrade
jbrowse-plugin-apollo
to the latest version of@jbrowse/core
, I got build errors about not being able to find various babel runtime files. This PR fixes those errors.