Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the ref name box when assembly is changed in LGV import form #3133

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

garrettjstevens
Copy link
Collaborator

Fixes #3126

@garrettjstevens garrettjstevens added the bug Something isn't working label Aug 11, 2022
@garrettjstevens garrettjstevens self-assigned this Aug 11, 2022
@garrettjstevens garrettjstevens linked an issue Aug 11, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #3133 (782d7e7) into main (ad9bf14) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3133      +/-   ##
==========================================
- Coverage   58.81%   58.79%   -0.03%     
==========================================
  Files         648      648              
  Lines       29042    29043       +1     
  Branches     7067     7067              
==========================================
- Hits        17082    17075       -7     
- Misses      11581    11589       +8     
  Partials      379      379              
Impacted Files Coverage Δ
...iew/src/LinearGenomeView/components/ImportForm.tsx 77.33% <0.00%> (-1.05%) ⬇️
...svg/src/SvgFeatureRenderer/components/Segments.tsx 85.71% <0.00%> (-7.15%) ⬇️
...src/SvgFeatureRenderer/components/FeatureLabel.tsx 80.55% <0.00%> (-5.56%) ⬇️
...gins/svg/src/SvgFeatureRenderer/components/util.ts 91.83% <0.00%> (-4.09%) ⬇️
...FeatureRenderer/components/ProcessedTranscript.tsx 87.32% <0.00%> (-1.41%) ⬇️
packages/core/util/layouts/GranularRectLayout.ts 86.86% <0.00%> (-0.43%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin
Copy link
Collaborator

thanks for checking this out. I tried changing hg19 -> chm13 in https://jbrowse.org/code/jb2/3126-lgv-search-box-not-updating-on-genome-change/?config=test_data%2Fconfig_demo.json&session=share-l7F3ZDWWCL&password=58PjL but it did not seem to update the text field from 1 to chr1 (which chm13 uses)

@garrettjstevens
Copy link
Collaborator Author

@cmdcolin that's odd, it works on a development build of this branch, but not in the deployed version. I'll have to look into that. Thanks for noticing.

@garrettjstevens
Copy link
Collaborator Author

It seems to be something unique to the session @cmdcolin shared above. If I open that shared session, it doesn't work, but then if I refresh the page it does work, even though if I export the session it's exactly the same. I also can't reproduce the non-working version any way I try except for clicking on that shared session link. Even if I re-share the shared session without changing anything, it still works.

@cmdcolin
Copy link
Collaborator

maybe if we see the issue continue we can add another fix, this seems to fix it. even the link i said didn't work above maybe now works for me

@cmdcolin
Copy link
Collaborator

can merge for now

@cmdcolin cmdcolin merged commit b242521 into main Aug 19, 2022
@cmdcolin cmdcolin deleted the 3126-lgv-search-box-not-updating-on-genome-change branch August 19, 2022 19:46
@cmdcolin cmdcolin changed the title In LGV import, update sequence when assembly is changed Update the ref name box when assembly is changed in LGV import form Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linear Genome View Search Box Not Updating on Genome Change
2 participants