Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For loop await results in slow download? #59

Closed
cmdcolin opened this issue Oct 12, 2019 · 1 comment
Closed

For loop await results in slow download? #59

cmdcolin opened this issue Oct 12, 2019 · 1 comment

Comments

@cmdcolin
Copy link
Contributor

This module uses await in a for loop. I think it should queue up all downloads, and then if it needs to be in order keep the promises in order, and then unpack.
@cmdcolin
Copy link
Contributor Author

cmdcolin commented Jan 9, 2024

can probably close. there is early return shortcut in loop so might as well not download in parallel

@cmdcolin cmdcolin closed this as completed Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cmdcolin