Docker doesn't work with GNS3 VM 1.5.4 #1994
Comments
|
Using the official GNS3 VM v1.5.3 and updating the gns3-server to 1.5.4 with "pip3 install" (not using the Upgrade function from the menu) results in a working configuration. I assume, that the latest docker in the GNS3 VM creates some trouble. The old docker version 1.12.6 from the GNS3 VM 1.5.3 seems to work better. |
|
Verified it:
|
ghost
changed the title
|
Hmm sound like docker it self broke gns3
Le jeu. 20 avr. 2017 à 14:06, Bernhard Ehlers <notifications@github.com> a
écrit :
… Verified it:
- Installing GNS3 VM v1.5.3 and updating it with "pip3 install
gns3-server==1.5.4" results in a working docker environment.
- After updating docker to 17.04.0-ce with "apt-get update; apt-get
install docker-engine" a docker VM stops automatically after a start.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1994 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAVFXV7QLRJs86N6gUDTkfWHxp8wKAz-ks5rx0o7gaJpZM4NC5dA>
.
|
|
According to https://www.gns3.com/qa/gns3-1-5-4-ubuntu-container-stop 2.0.0rc4 is also affected. |
|
It's probably affect also all users installing docker from their offical
repository.
…On Thu, Apr 20, 2017 at 3:06 PM Bernhard Ehlers ***@***.***> wrote:
According to https://www.gns3.com/qa/gns3-1-5-4-ubuntu-container-stop
2.0.0rc4 is also affected.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1994 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAVFXYTBtf3EWrgRli1pkRmRZ6W5iu8Bks5rx1hegaJpZM4NC5dA>
.
|
|
It works with the latest stable docker version 17.03.1-ce, the next (unstable) version 17.04.0-ce has this issue. I've installed those versions as documented in https://store.docker.com/editions/community/docker-ce-server-ubuntu?tab=description , my /etc/apt/sources.list.d/docker.list looks like this: |
|
I will freeze the docker version provided in the GNS3 VM |
|
Ok if user run upgrade in the GNS3 VM the previous release is installed. Now we need to understand what is wrong with the edge version |
|
Doesn't the requirement for api 1.27 mean, that the GNS3 server won't run with docker versions earlier than v17.03.1-ce? For the GNS3 VM that's not a problem, you can take care about that. But I fear, that a lot of linux GNS3 installations will stop working with docker VMs, because their docker version is older. |
|
Have you tried your changes in 2.0.0dev13 with docker version 17.04.0-ce? In my environment it still doesn't work. I'm pretty sure, that the reason, why docker API 1.28 doesn't work, is the following change in 17.04.0-ce:
Your patches changed the docker call in http_query (which shouldn't be necessary), but missed the docker call in websocket_query. Additionally changing that call, docker works also with 17.04.0-ce. Even after removing your change in http_query, it works. Here my patch to websocket_query: |
Fix GNS3/gns3-gui#1994 Signed-off-by: Julien Duponchelle <julien@gns3.net>
|
It's tested only against the stable version of docker not the edge. I will
apply your patch it seem to be the correct fix.
…On Fri, Apr 28, 2017 at 1:21 PM Bernhard Ehlers ***@***.***> wrote:
Have you tried your changes in 2.0.0dev13 with docker version 17.04.0-ce?
In my environment it still doesn't work.
I'm pretty sure, that the reason, why docker API 1.28 doesn't work, is the
following change in 17.04.0-ce:
- Use binary frame for websocket attach endpoint moby/moby#30460
<moby/moby#30460>
Your patches changed the docker call in http_query (which shouldn't be
necessary), but missed the docker call in websocket_query. Additionally
changing that call, docker works also with 17.04.0-ce. Even after removing
your change in http_query, it works.
Here my patch to websocket_query:
diff --git a/gns3server/compute/docker/__init__.py b/gns3server/compute/docker/__init__.py
index 53b4a7a..7b3e4d9 100644
--- a/gns3server/compute/docker/__init__.py
+++ b/gns3server/compute/docker/__init__.py
@@ -161,7 +161,7 @@ class Docker(BaseManager):
:returns: Websocket
"""
- url = "http://docker/" + path
+ url = "http://docker/v" + DOCKER_MINIMUM_API_VERSION + "/" + path
connection = yield from aiohttp.ws_connect(url,
connector=self.connector(),
origin="http://docker",
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#1994 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAVFXSqbppJBYM3xIzAEE2g1Oc3CRcuCks5r0cudgaJpZM4NC5dA>
.
|
Fix GNS3/gns3-gui#1994 Signed-off-by: Julien Duponchelle <julien@gns3.net>
GNS3 version 1.5.4 on Darwin (64-bit) with Python 3.5.2 Qt 5.6.0, official GNS3 VM 1.5.4
The OS X version and the GNS3 VM freshly downloaded and configured. Only the GNS3 VM (in VMware Fusion) and an alpine docker VM is configured.
Then I created a project and added an alpine VM. Starting the alpine VM works, but a few seconds it automatically stops. Running the docker alpine VM from the command line of the GNS3 VM works.
The server logs (with debug):
The text was updated successfully, but these errors were encountered: