Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devops/enable conda tests #1031

Merged
merged 3 commits into from
Aug 30, 2022
Merged

Conversation

guacke
Copy link
Contributor

@guacke guacke commented Aug 27, 2022

Short description

While the build-tests are failing in PR #1030, the conda builds seem ok. However, this is because the test are apparently disabled in the conda build. I will re-enable them in this PR.

Tagging @xdvriend .

@guacke guacke changed the base branch from develop to bugfix/1ZeroUNOCI August 27, 2022 10:26
@guacke
Copy link
Contributor Author

guacke commented Aug 28, 2022

@xdvriend Conda reports an error in GLowdinPairingBasis_test.cpp.

@xdvriend
Copy link
Contributor

xdvriend commented Aug 29, 2022

@xdvriend Conda reports an error in GLowdinPairingBasis_test.cpp.

I'v been looking into it, but I can't reproduce this error. (completely deleted and reinstalled GQCP, using the exact same settings as the GitHub actions build) It is also strange that the error would occur while building the GLowdinPairingBasis_test.cpp, as I've never had any issues with calculations in a generalised basis.

Do all Conda builds raise this error? Or are others just being cancelled, as we've sometimes had issues with that as well, which are often solved by just restarting the build.

@xdvriend
Copy link
Contributor

Since the conda builds are being cancelled on other PR's as well, I believe this might be the same thing happening here. I don't think GLowdinPairingBasis_test.cpp is causing the builds to fail.

@xdvriend xdvriend marked this pull request as ready for review August 30, 2022 14:45
@xdvriend xdvriend merged commit 3b33050 into bugfix/1ZeroUNOCI Aug 30, 2022
@xdvriend xdvriend deleted the devops/enable-conda-tests branch August 30, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants