A Django command that scans files at rest #3285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given a path, it will scan everything. Given a single object, it will scan one thing
I was passing params wrong to the SimpleUploadedFile creation. Fixed.
…o instead log errors at the point of each scan.
|
Terraform plan for meta No changes. Your infrastructure matches the configuration.✅ Plan applied in Deploy to Development and Management Environment #514 |
|
Terraform plan for dev Plan: 0 to add, 1 to change, 0 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~ update in-place
Terraform will perform the following actions:
# module.dev.module.https-proxy.cloudfoundry_app.egress_app will be updated in-place
!~ resource "cloudfoundry_app" "egress_app" {
id = "a6eb3870-2769-4aa9-a8f2-f1a31939f563"
name = "https-proxy"
!~ source_code_hash = "cfddd8df06cdb61c6b5a5fe8b879a9ad5b8eeb0752a9f7d73bf4ae050184e237" -> "48b2f5eba8d1f35c0fbc2f90c2ec87cab180f5f19e7e34b16b9190fe5c5ca09a"
# (19 unchanged attributes hidden)
# (1 unchanged block hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.
Warning: Argument is deprecated
with module.dev.module.cg-logshipper.module.s3-logshipper-storage.cloudfoundry_service_instance.bucket,
on /tmp/terraform-data-dir/modules/dev.cg-logshipper.s3-logshipper-storage/s3/main.tf line 14, in resource "cloudfoundry_service_instance" "bucket":
14: recursive_delete = var.recursive_delete
Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases
(and 3 more similar warnings elsewhere)✅ Plan applied in Deploy to Development and Management Environment #514 |
danswick
approved these changes
Jan 25, 2024
14 tasks
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 2ec5bfb |
danswick
deleted the
tadhg/jadudm-scan-files-at-rest-for-viruses-signed
branch
purvinptl
pushed a commit
that referenced
this pull request
Jan 25, 2024
* A Django command that scans files at rest Given a path, it will scan everything. Given a single object, it will scan one thing * Passed parameters wrong I was passing params wrong to the SimpleUploadedFile creation. Fixed. * Fix the empty case. * Linted. * Change AV scan code path to not assemble a list of all results, but to instead log errors at the point of each scan. * Switch Django command for AV scan of S3 objects to use pagination. --------- Co-authored-by: Matt Jadud <matthew.jadud@gsa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same as #2705 but with signed commits.
#2693
This is a Django command that can do one of two things:
Common calling patterns will be:
fac scan_bucket_files_for_viruses --bucket gsa-fac-private-s3 --path singleauditreportfac scan_bucket_files_for_viruses --bucket gsa-fac-private-s3 --path excelThis should be testable locally, and once merged, we can test it in
dev. If it can be run manually indev, we can then build an associated GH Action to trigger it.This does not write to any files, and therefore is not a risk to data. It does generate log messages.
sfv.mp4
PR checklist: submitters
maininto your branch shortly before creating the PR. (You should also be mergingmaininto your branch regularly during development.)git status | grep migrations. If there are any results, you probably need to add them to the branch for the PR. Your PR should have only one new migration file for each of the component apps, except in rare circumstances; you may need to delete some and re-runpython manage.py makemigrationsto reduce the number to one. (Also, unless in exceptional circumstances, your PR should not delete any migration files.)PR checklist: reviewers
make docker-clean; make docker-first-run && docker compose up; then rundocker compose exec web /bin/bash -c "python manage.py test"The larger the PR, the stricter we should be about these points.