Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a line returns to list items and making events conditional on homepage #223

Merged
merged 13 commits into from
Nov 17, 2017

Conversation

jeremyzilar
Copy link
Contributor

@jeremyzilar jeremyzilar commented Nov 16, 2017

What was improved

@jeremyzilar jeremyzilar self-assigned this Nov 16, 2017
@jeremyzilar jeremyzilar changed the title adding a line return to make list items function Adding a line returns to make list items function Nov 17, 2017
@jeremyzilar jeremyzilar changed the title Adding a line returns to make list items function Adding a line returns to list items and making events conditional on homepage Nov 17, 2017
@thisisdano
Copy link
Contributor

So, I don't want this to be a big deal, but I'd consider some of these kinds of changes more like a sprint release or a content release change. The way I see it:

patch release *.*.# — fixes errors: typos, missing or incorrect content or formatting
content release *.#.0 — new content and content design: new posts, articles, and resources; non-error changes to content design
sprint release #.0.0 — new or fixed site functionality: new components, new formatting, non-error fixes, improvements

How does that strike you? There's no need to hold off on these changes over a versioning discussion, but going forward it might make sense to be more strict. If only to keep us from hotfixing all the time, and limiting that to only when it's really necessary. It's annoying and sometimes painful from holding back on improvements, but it might help our workflow and sanity?

  • I don't have the time at this moment to check the conditional events, but it looks like it should work!
  • Dunno the reasoning behind removing the event type from the title, maybe just spell the reason out in the notes, or point to an issue?
  • Was there an issue behind removing the contact page? I'm sure it's fine to do it, but, as above, it could be helpful to have an issue as a documentation of reasoning

It may feel like I'm being a bit of a process stickler here, and I guess I am a bit. But the process is the product to some degree here.

@jeremyzilar jeremyzilar merged commit a2c3b61 into master Nov 17, 2017
@jeremyzilar jeremyzilar deleted the release-2.1.1 branch March 26, 2018 21:45
@dailybreade03
Copy link

  • [@]()

@dailybreade03
Copy link

  • -

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants