Adds Mesh implementation
#387
Conversation
|
This is still a draft, but I thought I'd open this already so that you guys can have a peek too and let me know what you think. I'll do a review in a bit to highlight the most "controversial" changes ;) |
There was a problem hiding this comment.
Fantastic work @AlanRynne! Thanks again for implementing this, looks (unsurprisingly) great! :)
Left a couple of comments for review.
| /// Returns a normalized copy of this vector. | ||
| /// </summary> | ||
| /// <returns>A copy of this vector unitized.</returns> | ||
| public Vector3 Unit() |
There was a problem hiding this comment.
@AlanRynne, any reason not to use the existing methods Unitize() CrossProduct() and DotProduct() directly?
| namespace GShark.Geometry | ||
| { | ||
| /// <summary> | ||
| /// Represents a mesh half-edge. |
There was a problem hiding this comment.
Edge class representing a mesh half-edge.
| /// </summary> | ||
| /// <returns>The face area.</returns> | ||
| /// <param name="face">Face.</param> | ||
| public static double Area(MeshFace face) |
There was a problem hiding this comment.
There's a method in Polygon to calculate the area from an arbitrary list of points that form a closed planar boundary. Currently implemented as a getter tho... We could make that a static method and re-use it here for arbitrary NGon area calcs?
d3ssy
added
the
enhancement 📢
What type of PR is this? (check all applicable)
Description
Adds several classes to the
Geometrynamespace to implement a half-edge mesh data-structure.It also adds some initial basic unit tests to ensure everything works as expected.
Related Tickets & Documents
Fixes #225
Added tests?
Added to documentation?