Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for translating Cryptol constraint guards #1911

Merged
merged 10 commits into from
Aug 18, 2023
Merged

Add support for translating Cryptol constraint guards #1911

merged 10 commits into from
Aug 18, 2023

Conversation

bboston7
Copy link
Contributor

Closes #1897.

This change adds support for translating Cryptol constraint guards into nested if-then-else expressions so that they may be reasoned about in SAW.

Add support for translating Cryptol constraint guards
918305b 
Closes #1897.

This change adds support for translating Cryptol constraint guards into
nested if-then-else expressions so that they may be reasoned about in
SAW.
@bboston7 bboston7 added the type: enhancement Issues describing an improvement to an existing feature or capability label Aug 15, 2023
@bboston7 bboston7 self-assigned this Aug 15, 2023
eddywestbrook
eddywestbrook reviewed Aug 15, 2023
View reviewed changes
Copy link
Contributor

@eddywestbrook eddywestbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Just some small issues with the comments / documentation

cryptol-saw-core/src/Verifier/SAW/Cryptol.hs Outdated Show resolved Hide resolved
RyanGlScott
RyanGlScott reviewed Aug 16, 2023
View reviewed changes
cryptol-saw-core/src/Verifier/SAW/Cryptol.hs Outdated Show resolved Hide resolved
cryptol-saw-core/src/Verifier/SAW/Cryptol.hs Outdated Show resolved Hide resolved
cryptol-saw-core/src/Verifier/SAW/Cryptol.hs Show resolved Hide resolved
intTests/test_constraint_guards/Test.cry Outdated Show resolved Hide resolved
cryptol-saw-core/saw/Cryptol.sawcore Outdated Show resolved Hide resolved
cryptol-saw-core/saw/Cryptol.sawcore Outdated Show resolved Hide resolved
RyanGlScott
RyanGlScott approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! Do mention these changes in the SAW changelog, since they're a user-facing feature. Otherwise, LGTM.

@bboston7 bboston7 added the PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run label Aug 17, 2023
@mergify mergify bot merged commit e0604ca into master Aug 18, 2023
38 checks passed
@mergify mergify bot deleted the bb/constraint-guards branch August 18, 2023 01:50
@bboston7 bboston7 mentioned this pull request Aug 29, 2023
Closed
@RyanGlScott RyanGlScott mentioned this pull request Mar 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanGlScott RyanGlScott RyanGlScott approved these changes

@m-yac m-yac Awaiting requested review from m-yac

@eddywestbrook eddywestbrook Awaiting requested review from eddywestbrook

Assignees

@bboston7 bboston7

Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run type: enhancement Issues describing an improvement to an existing feature or capability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for translating Cryptol constraint guards
3 participants
@bboston7 @eddywestbrook @RyanGlScott