Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace default bitcoind wallet with multiple purpose specific wallets #353

Closed
jotapea opened this issue Jul 20, 2021 · 1 comment
Closed

Comments

@jotapea
Copy link
Contributor

jotapea commented Jul 20, 2021

The current bitcoind tests implementation use a single "all encompassing" default wallet client which is used for many purposes. The goal is to split this one client/wallet into:

  • default client:

    • Only to be used for non-transaction wallet functionality (like: getBlockchainInfo, createWallet, listWallets, decodeRawTransaction, loadWallet, unloadWallet, getBlockCount?).
      • All code that uses the listWallets call needs to be updated to now consider the addition of new wallets.
      • A single getBlockCount function has been kept for the default wallet (TODO?).
  • outside wallet:

    • Represents the outside world, which is required for simulating transactions in tests.
    • This is replacing all tests from the original "" (unnamed) wallet that do transactions (generate, receive or send coins).
  • hot wallet:

    • FUTURE use, will eventually replace the lnd onchain wallet.
    • The scope of this one at this phase is only to be added as another wallet in the tests.
This was referenced Jul 20, 2021
@jotapea
Copy link
Contributor Author

jotapea commented Jul 20, 2021

@nicolasburtey PR #354 is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants