Repository navigation
Replies: 3 comments
|
Hey @udiNur, thanks for asking first, and for #1072! Short version: yes to all four, as separate PRs. 1. Nest mode: yes please. Lock mode still keeps the leader for itself, so it can't drive a nested tuios or tmux, and that's exactly the gap this fills. A few shape notes:
2. One session order for every client: yes, and this should also fix #892, so please link it with "Fixes #892". The daemon owning it, the same way as 3. Finder ready to type: yes, small and nice. I'd do it as an option on the action rather than a second action, so one key can do either. A setting like 4. Touch scroll in the strip: I like it. tuios-web just got a new opt-in renderer with its own touch layer (sip v0.10.0), so build it on top of that. A tap, a vertical swipe and a long press already have meanings there, so a horizontal drag fits. Snap to the nearest column at the end of the gesture sounds great, as an option. For all of them: plain short UI text, and e2e over unit tests (AGENTS.md has the details). Looking forward to these! |
|
Thanks again for the quick yes! All four are up now, each as its own PR on current main, and CI is green on all of them:
Each one has e2e tests and negative controls, and I followed AGENTS.md as closely as I could. Is there anything you'd like done differently before you review? For example, a more thorough review pass on my side, a different split, or a specific area you'd like tested more. I'm happy to do whatever makes them easier for you to land. |
Uh oh!
There was an error while loading. Please reload this page.
Hi @Gaurav-Gosain, thanks again for landing #1072. I moved over from tmux, and there are a few things I miss or would like to add. Before I polish any of them into PRs, I'd like to know which ones you'd want upstream, and how you'd want them shaped.
1. A nest mode for a nested multiplexer.
prefix Entersends every key to the focused pane,ctrl+bincluded, until a configurable exit key (F12by default). The pane shows a "NEST" badge while it's on. It's the tmux-matryoshka workflow: run tmux or another tuios inside a pane and drive it without tuios catching its prefix. I have it working on a branch, with e2e tests (a nested tmux gets its ownctrl+b) and negative controls.send_prefixsends one prefix andlockis a setting, so neither covers this today.2. One session order for every client. When I reorder sessions from one client, for example over SSH from my phone, the order on my Mac doesn't change. On my branch the daemon owns the order, the same way it owns
DisplayNameandAccent. A move goes through a daemon action, and every client gets it throughMsgSessionsChanged. This looks close to #892 (a drag-set order snapping back with several clients) and follows the rule in #162. Sessions from other machines in the rail still keep a per-client order.3. Open the pane finder ready to type.
choose_treeopens on the list, so finding a pane isprefix /then/. An action, or an option, that opens it with the search line focused would make it one step. This one is small, and I haven't written it yet.4. Touch: scroll the strip with a finger. In the
scrollinglayout, horizontal wheel withAltalready moves the strip byniri_scroll_cells. On a phone or tablet there is no way to drag it. I'm thinking of horizontal drag in tuios-web, and maybe an optional snap to the nearest column when the gesture ends, like niri. This is only an idea for now.Which of these would you be interested in? I'm happy to open them as separate PRs, change the names or the approach, or keep any of them in my fork if they don't fit.
All reactions