Update G4OptionalComponents.cmake #16
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR should fix the compilation with -DGEANT4_USE_SYSTEM_PTL:BOOL=ON with PTL 1.0.0.
jrmadsen
suggested changes
Jan 8, 2021
There was a problem hiding this comment.
PTL::ptl is an interface target which is set to provide either PTL::ptl-shared or PTL::ptl-static. This change will break if PTL is built with only static libraries and will probably break Geant4 static library builds which, I believe, don't compile with -fPIC so you can't link to dynamic targets.
|
This has been integrated in the upstream development repo and will be in the next patch. Many thanks for you contribution @andriish ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix the compilation with -DGEANT4_USE_SYSTEM_PTL:BOOL=ON with PTL 1.0.0.