Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the deprecated load_hotspots function (deprecated since v0.6.0) #2309

Merged
merged 20 commits into from Jan 19, 2023
Merged

Remove the deprecated load_hotspots function (deprecated since v0.6.0) #2309

merged 20 commits into from Jan 19, 2023

Conversation

michaelgrund
Copy link
Member

Description of proposed changes

Related to #2302

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@michaelgrund michaelgrund added the deprecation Deprecating a feature label Jan 4, 2023
@michaelgrund michaelgrund added this to the 0.9.0 milestone Jan 4, 2023
@michaelgrund michaelgrund mentioned this pull request Jan 4, 2023
Closed
7 tasks
@michaelgrund
Copy link
Member Author

/format

@michaelgrund michaelgrund self-assigned this Jan 4, 2023
@michaelgrund @willschlitzer
Apply suggestions from code review
6adbb2d 
Co-authored-by: Will Schlitzer <schlitzer90@gmail.com>
@yvonnefroehlich yvonnefroehlich changed the title Remove the deprecated load_hotspots function (deprecated since v0.6.0) #2305 Remove the deprecated load_hotspots function (deprecated since v0.6.0) Jan 4, 2023
@michaelgrund @yvonnefroehlich
Apply suggestions from code review
955ce85 
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
@michaelgrund
Copy link
Member Author

/format

@michaelgrund michaelgrund added the needs review This PR has higher priority and needs review. label Jan 9, 2023
seisman
seisman approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except minor comments.

pygmt/datasets/samples.py Outdated Show resolved Hide resolved
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Jan 10, 2023
seisman
seisman reviewed Jan 10, 2023
View reviewed changes
pygmt/datasets/samples.py Outdated Show resolved Hide resolved
@seisman seisman added needs review This PR has higher priority and needs review. and removed final review call This PR requires final review and approval from a second reviewer labels Jan 10, 2023
@michaelgrund @yvonnefroehlich @seisman
Apply suggestions from code review
a765dbb 
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
seisman reviewed Jan 11, 2023
View reviewed changes
pygmt/datasets/samples.py Outdated Show resolved Hide resolved
seisman
seisman reviewed Jan 11, 2023
View reviewed changes
pygmt/datasets/samples.py Outdated Show resolved Hide resolved
seisman
seisman reviewed Jan 11, 2023
View reviewed changes
pygmt/datasets/samples.py Outdated Show resolved Hide resolved
@michaelgrund @seisman
Apply suggestions from code review
3b251d8 
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@seisman
Copy link
Member

seisman commented Jan 12, 2023

/format

@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Jan 12, 2023
@michaelgrund @yvonnefroehlich
Apply suggestions from code review
534b622 
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
yvonnefroehlich
yvonnefroehlich approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@yvonnefroehlich yvonnefroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside my question above, I feel this looks good!

@yvonnefroehlich yvonnefroehlich removed the final review call This PR requires final review and approval from a second reviewer label Jan 14, 2023
@seisman
Copy link
Member

seisman commented Jan 19, 2023

Ping @michaelgrund to address the comment #2309 (comment) and resolve the conflicts.

@michaelgrund michaelgrund added the needs review This PR has higher priority and needs review. label Jan 19, 2023
@michaelgrund
Copy link
Member Author

/format

@seisman seisman enabled auto-merge (squash) January 19, 2023 07:57
@seisman seisman merged commit 45f2c4c into main Jan 19, 2023
@seisman seisman deleted the deprecate-load_hotspots branch January 19, 2023 08:10
@michaelgrund michaelgrund removed the needs review This PR has higher priority and needs review. label Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seisman seisman seisman approved these changes

@willschlitzer willschlitzer willschlitzer left review comments

@yvonnefroehlich yvonnefroehlich yvonnefroehlich approved these changes

Assignees

@michaelgrund michaelgrund

Labels
deprecation Deprecating a feature
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@michaelgrund @seisman @willschlitzer @yvonnefroehlich @actions-bot