Skip to content

Conversation

seisman
Copy link
Member

@seisman seisman commented Mar 7, 2023

Description of proposed changes

Preview at https://pygmt-dev--2402.org.readthedocs.build/en/2402/api/generated/pygmt.GMTDataArrayAccessor.html#pygmt.GMTDataArrayAccessor.gtype

Python class properties shown for GMTDataArrayAccessor

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to me, was there anything else you wanted to add?

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog documentation Improvements or additions to documentation and removed maintenance Boring but important stuff for the core devs labels Mar 7, 2023
@seisman seisman added this to the 0.9.0 milestone Mar 7, 2023
@seisman seisman marked this pull request as ready for review March 7, 2023 23:36
@seisman seisman added the needs review This PR has higher priority and needs review. label Mar 7, 2023
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. final review call This PR requires final review and approval from a second reviewer labels Mar 9, 2023
@seisman seisman merged commit 5364749 into main Mar 11, 2023
@seisman seisman deleted the class-tempaltes branch March 11, 2023 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants