Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use macos-13 for Tests Dev workflow and consistently use lower-case runner names #2516

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

seisman
Copy link
Member

@seisman seisman commented Apr 25, 2023

Description of proposed changes

  1. Use macos instead of macOS for runner names, following the official documentation
  2. Use macos-13 instead of macos-12 in the "Tests Dev" workflow

Reference: https://github.blog/changelog/2023-04-24-github-actions-macos-13-is-now-available/

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Apr 25, 2023
@seisman seisman added this to the 0.10.0 milestone Apr 25, 2023
@seisman
Copy link
Member Author

seisman commented Apr 25, 2023

image

All workflows still pass. Need to update the branch protection rules after merging.

@seisman seisman added the needs review This PR has higher priority and needs review. label Apr 25, 2023
@seisman seisman requested a review from weiji14 April 26, 2023 03:55
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, so according to https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources, GitHub Actions currently has 3 runners for macOS:

  • macos-11 Big Sur - used in ci_tests_legacy.yaml
  • macos-12/macos-latest Monterey - used in most of our ci_*.yml files
  • macos-13 Ventura [Beta] - used in ci_tests_dev.yaml

Looks ok to me!

@seisman seisman merged commit 14c07b4 into main Apr 26, 2023
@seisman seisman deleted the ci-macos branch April 26, 2023 04:26
@seisman seisman removed the needs review This PR has higher priority and needs review. label Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants