Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use macos-14 for GMT Dev Tests workflow #3024

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Jan 30, 2024

Description of proposed changes

Use macos-14 (Sonoma) instead of macos-13 (Ventura) in the "GMT Dev Tests" workflow, available since 30 Jan 2024. Note that this uses the M1 Chips!

After merging this PR, we will have tests on 3 versions of macOS:

  • macos-11 Big Sur - used in ci_tests_legacy.yaml
  • macos-13/macos-latest Ventura - used in most of our ci_*.yml files
  • macos-14 Sonoma - used in ci_tests_dev.yaml

Should we also change ci_tests_legacy.yaml to use macos-12 instead of macos-11? It seems like they marked macos-11 as deprecated in actions/runner-images#9252, but we can probably use it for a while longer.

References:

Supersedes #2516

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash command is:

  • /format: automatically format and lint the code

@weiji14 weiji14 added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Jan 30, 2024
@weiji14 weiji14 self-assigned this Jan 30, 2024
@weiji14 weiji14 added the run/test-gmt-dev Trigger the GMT Dev Tests workflow in PR label Jan 30, 2024
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There are 3 failing x2sys_cross tests, which are more likely due to upstream issues.

@seisman seisman added this to the 0.12.0 milestone Feb 2, 2024
@seisman seisman added run/test-gmt-dev Trigger the GMT Dev Tests workflow in PR and removed run/test-gmt-dev Trigger the GMT Dev Tests workflow in PR labels Feb 3, 2024
@weiji14 weiji14 marked this pull request as ready for review February 4, 2024 21:46
@weiji14 weiji14 merged commit 4b7cb2a into main Feb 4, 2024
12 of 17 checks passed
@weiji14 weiji14 deleted the ci/macos-14-dev branch February 4, 2024 21:55
@weiji14 weiji14 removed the run/test-gmt-dev Trigger the GMT Dev Tests workflow in PR label Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants