-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEP29: Test PyGMT on NumPy 1.26 #2692
Conversation
83dbd71
to
99ce9b6
Compare
Need to wait for conda-forge/numpy-feedstock#297 |
After bumping NumPy 1.25 to 1.26, we have 170 failures. These failures are all caused by the Ghostscript versions. For unknown reasons (complicated package dependency), with NumPy 1.25, gs 9.54 is installed but with NumPy 1.26, gs 10.02.0 is installed. |
We have a few options to address these failures:
|
We'll need to update the baseline images for gs 10.02.0 eventually, so I'd prefer option 2. But I'm worried if we can't install gs 10.02 on Python 3.9 / NumPy 1.22, causing the tests to fail when we update the base images 😅 |
Pin gs to 10.02.0 seems working #2694 for the Tests CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description of proposed changes
Bumps numpy from 1.25 to 1.26. NumPy 1.26.0 was released on 18 Jun 2023.
This is in line with PyGMT's policy on NEP29 at https://www.pygmt.org/v0.9.0/maintenance.html#dependencies-policy, xref #1074.
Note that the branch protection rules at GenericMappingTools/pygmt/settings/branches will need to be changed to use Python 3.11/Numpy 1.26 instead of Python 3.11/Numpy 1.25 before this Pull Request is merged.
Supersedes #2581
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version