Skip to content

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Aug 26, 2020

Description of proposed changes

Fixes failing style checks due to pylint 2.6.0 adding a new "raise-missing-from" check for exceptions that should have a cause. The try-except cause needs to be re-written as:

try:
    # do something
except Error as e:
    raise GMTInvalidInput("some better error message") from e

See also:

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

@weiji14 weiji14 added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Aug 26, 2020
@weiji14 weiji14 requested a review from seisman August 26, 2020 21:20
@weiji14 weiji14 merged commit 882b5b2 into master Aug 26, 2020
@weiji14 weiji14 deleted the pylint-fix-w0707 branch August 26, 2020 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants