Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

39 adjusted standard errors #64

Merged
merged 30 commits into from
Aug 6, 2023
Merged

39 adjusted standard errors #64

merged 30 commits into from
Aug 6, 2023

Conversation

marklhc
Copy link
Collaborator

@marklhc marklhc commented Jul 30, 2023

No description provided.

#' of factor `"_by_"` factor scores, and the error variance-covariance
#' of the factor scores (with prefix `"evfs_"`). The following are
#' also returned as attributes:
#' * `fsT`: error covariance of factor scores
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is fsT the new name of vc?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Winnie, yes I should have mentioned this earlier. I now used fsT for the Theta (error covariance) matrix of factor scores, and fsL for the loading matrix.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarifications!

Copy link
Collaborator

@winniewytse winniewytse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have a few minor suggestions for the vignette. The overall picture of the correction is clear. I think I need a bit more time to understand how to derive the Jacobian matrix. But once we get the Jacobian matrix, I think it's straightforward to get the correction. Thanks for putting things together and cleaning up all the scripts!

#' of factor `"_by_"` factor scores, and the error variance-covariance
#' of the factor scores (with prefix `"evfs_"`). The following are
#' also returned as attributes:
#' * `fsT`: error covariance of factor scores
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarifications!

vignettes/corrected-se.Rmd Outdated Show resolved Hide resolved
vignettes/corrected-se.Rmd Outdated Show resolved Hide resolved
vignettes/corrected-se.Rmd Outdated Show resolved Hide resolved
vignettes/corrected-se.Rmd Show resolved Hide resolved
@marklhc
Copy link
Collaborator Author

marklhc commented Aug 6, 2023

Thanks Winnie!

@marklhc marklhc merged commit 7ef1ee7 into devel Aug 6, 2023
@marklhc marklhc deleted the 39-adjusted-standard-errors branch August 7, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants