-
Notifications
You must be signed in to change notification settings - Fork 0
chore: add verify_ssl flag #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request adds a 'verify_ssl' flag to various functions that make HTTP requests, allowing for SSL certificate verification to be optionally disabled. The changes are implemented across multiple files, updating function signatures, call sites, and tests to accommodate this new parameter. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @brunopacheco1 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a warning log when SSL verification is disabled to prevent accidental use in production environments.
- Ensure thorough testing, particularly for code paths where SSL verification is disabled, due to the widespread nature of these changes.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 3 issues found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
a69b7cd
to
d0c6491
Compare
Summary by Sourcery
Add a 'verify_ssl' flag to functions handling HTTP requests to allow optional SSL certificate verification, and update tests to accommodate this new parameter.
Enhancements:
Tests: