Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swipe on left side when fullscreen #357

Closed
ivantyr opened this issue Nov 26, 2018 · 2 comments
Closed

Swipe on left side when fullscreen #357

ivantyr opened this issue Nov 26, 2018 · 2 comments

Comments

@ivantyr
Copy link

ivantyr commented Nov 26, 2018

I find this a little hard to describe, but when performing a swipe motion on the left side of the screen only when on fullscreen, the swipe jumps to the other side of the screen, this does not happen on any of the other 3 sides and also doesn't happen while on windowed mode

Here's a short video that might describe it better
https://giant.gfycat.com/AlarmingKindheartedGenet.webm

@rom1v
Copy link
Collaborator

rom1v commented Nov 27, 2018

Thank you for your report.

Could you try again with the current master version, please? This issue might be solved by a7fe9ad.

EDIT: arf, my fix ignores all events outside the device screen, which is not good: a "drop" of a drag&drop outside the screen is not dispatched. I will change to project the outside-the-screen events to the border of the screen.

rom1v added a commit that referenced this issue Nov 27, 2018
Mouse events position were unsigned (so negative values could not be
handled properly).

To avoid issues with negative values, mouse events outside the device
screen were ignored (commit a7fe9ad).

But as a consequence, drag&drop were "broken" if the "drop" occurred
outside the device screen.

Instead, use signed 32-bits to store the position, and forward events
outside the device screen.

Fixes <#357>.
@rom1v
Copy link
Collaborator

rom1v commented Nov 27, 2018

arf, my fix ignores all events outside the device screen, which is not good: a "drop" of a drag&drop outside the screen is not dispatched.

I provided a better fix on the dev branch: fefb981.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants