Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input thread errors when certain functions don't exist like expandNotificationsPanel #506

Closed
MatthewScholefield opened this issue Apr 23, 2019 · 2 comments
Closed

Input thread errors when certain functions don't exist like expandNotificationsPanel #506

MatthewScholefield opened this issue Apr 23, 2019 · 2 comments
Labels
bug

Comments

@MatthewScholefield
Copy link

It appears my phone (Oneplus 3) doesn't have an expandNotificationsPanel function so when I press ctrl+n I get:

java.lang.AssertionError: java.lang.NoSuchMethodException: expandNotificationsPanel []
	at com.genymobile.scrcpy.wrappers.StatusBarManager.<init>(StatusBarManager.java:20)
	at com.genymobile.scrcpy.wrappers.ServiceManager.getStatusBarManager(ServiceManager.java:67)
	at com.genymobile.scrcpy.Device.collapsePanels(Device.java:140)
	at com.genymobile.scrcpy.EventController.executeCommand(EventController.java:179)
	at com.genymobile.scrcpy.EventController.handleEvent(EventController.java:81)
	at com.genymobile.scrcpy.EventController.control(EventController.java:61)
	at com.genymobile.scrcpy.Server$1.run(Server.java:40)
	at java.lang.Thread.run(Thread.java:764)
Caused by: java.lang.NoSuchMethodException: expandNotificationsPanel []
	at java.lang.Class.getMethod(Class.java:2068)
	at java.lang.Class.getMethod(Class.java:1690)
	at com.genymobile.scrcpy.wrappers.StatusBarManager.<init>(StatusBarManager.java:17)
	... 7 more

Afterwards, input no longer works. Perhaps this should be caught and ignored (or outputted as a message to the console)?
@rom1v rom1v added the bug label Apr 23, 2019
@rom1v
Copy link
Collaborator

rom1v commented Apr 23, 2019

Thank you for the report.

rom1v added a commit that referenced this issue May 4, 2019
@rom1v
Recover if expand/collapse panels is not available
c8338b2 
Some devices don't have the required method. Recover gracefully without
crashing the server.

Fixes <#506>.
@rom1v
Copy link
Collaborator

rom1v commented May 4, 2019

Fixed on dev.

@rom1v rom1v closed this as completed May 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rom1v @MatthewScholefield