Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scrcpy-noconsole.exe shows a console #691

Closed
tordenflesk opened this issue Aug 5, 2019 · 14 comments
Closed

scrcpy-noconsole.exe shows a console #691

tordenflesk opened this issue Aug 5, 2019 · 14 comments
Labels
bug windows

Comments

@tordenflesk
Copy link

tordenflesk commented Aug 5, 2019 •
edited
Loading

scrcpy-noconsole.exe shows a console after upgrading to 1.10
@jimnordb
Copy link

jimnordb commented Aug 6, 2019

Can confirm.

image

@thorito
Copy link

thorito commented Aug 7, 2019 •
edited
Loading

Idem
image

Invocation: C:\programming\scrcpy-win64-v1.10\scrcpy-noconsole.exe -Tts 123456789

@rom1v
Copy link
Collaborator

rom1v commented Aug 7, 2019

Indeed.

Even if I rebuild v1.9 with my current mingw, the "no console" flag (-mwindow) does not work.

It's probably a bug in mingw.

@rom1v
Copy link
Collaborator

rom1v commented Aug 7, 2019 •
edited
Loading

From IRC:

mingw-w64 does require you to use WinMain for -mwindows to work

I'll test that later.

https://stackoverflow.com/questions/13871617/winmain-and-main-in-c-extended

@dukemagus
Copy link

one more to confirme the bug

@sweenwolf
Copy link

Yeah I faced it too

@WrathX
Copy link

WrathX commented Aug 20, 2019

This is happening for me as well

@rom1v
Copy link
Collaborator

rom1v commented Aug 20, 2019

If someone wants to work on it, the solution is probably to use WinMain() instead of main() (#691 (comment)) in a #ifdef WINDOWS_NOCONSOLE block.

@wenmin92 wenmin92 mentioned this issue Aug 26, 2019
Merged
@rom1v rom1v mentioned this issue Aug 27, 2019
Closed
@nverbeek
Copy link

Same for me

@KeronCyst
Copy link

Same; I thought I was going crazy with my shortcut adjustment!

@icantremember
Copy link

Me too, but at least it shows the bugdroid as the console icon :)

@rom1v rom1v mentioned this issue Sep 13, 2019
Closed
@rom1v rom1v mentioned this issue Oct 9, 2019
Closed
@rom1v rom1v mentioned this issue Nov 5, 2019
Closed
rom1v added a commit that referenced this issue Nov 19, 2019
@rom1v
Fix noconsole.exe
18f2e33 
The linker flag "-mwindows" has no effect on my current MinGW.

Instead, passing "-Wl,--subsystem,windows" works.

Fixes <#691>
@rom1v
Copy link
Collaborator

rom1v commented Nov 19, 2019

I found a workaround: 18f2e33

I backported it on v1.10 so that you can test:

scrcpy-noconsole SHA256: f7722aa6c5a56fb215cea02395376863de83cc51b16be9e6b784a7923fbc611f

@fefo-dev
Copy link

fefo-dev commented Nov 19, 2019 •
edited
Loading

Using it along with #650 (comment) and no issues so far, the console never pops.

Spoke too soon, this binary doesn't implement the text fix, unsurprisingly. However no issues found with the server, if any should be expected.

@rom1v
Copy link
Collaborator

rom1v commented Nov 19, 2019

Fixed in v1.11.

@rom1v rom1v closed this as completed Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests